Restrict asset state store access to registered tasks#69764
Open
fat-catTW wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why:
Asset state store entries are scoped to assets, but execution API task tokens should not be able to access every active asset.
Previously, any task with a valid execution token could read or mutate state for unrelated assets. This made asset state store access broader than the task's declared asset relationships.
Solution:
Restrict the execution API asset state store routes so task tokens can only access assets registered to that task as an inlet or outlet.
The routes now check
TaskInletAssetReferenceandTaskOutletAssetReferencebefore allowing GET, PUT, DELETE, or CLEAR operations. Unregistered task access returns403 Forbidden.Watcher writes keep using the existing non-task path because watcher tokens are not backed by task instances.
Tests cover forbidden access for unregistered tasks and allowed access for inlet/outlet-registered tasks.
Was generative AI tooling used to co-author this PR?
[X]Yes (please specify the tool below)Generated-by: [Codex] following the guidelines
{pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.