UI: Preserve raw connection extra JSON#69741
Open
Vamsi-klu wants to merge 2 commits into
Open
Conversation
Editing a provider connection could serialize untouched provider defaults into extra JSON, overwriting values the user entered manually.
The UI change is visible to users editing provider connections, so the release notes should mention the bug fix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Editing a Snowflake connection in the UI could silently rewrite the raw
extraJSON. If the connection had manually entered extras such as{"account":"1234"}, opening and saving the form could replace that JSON with provider-field defaults like{"insecure_mode":false}.closes: #57984
What Changed
The connection form now preserves the raw
extraJSON as the source of truth for keys that the user did not change through provider-specific fields.Provider extra fields are initialized from matching keys in the raw JSON, but untouched provider defaults are not serialized back into the JSON. When a user edits a provider field, only that changed key is merged into the existing JSON. Clearing a provider field removes that key while preserving unrelated keys.
Impact
Users can safely edit Snowflake connections without losing manually configured extras. Existing raw JSON keys are preserved, and defaults such as
insecure_mode: falseare not injected unless the user explicitly changes the field.Testing
pnpm exec vitest run src/queries/useParamStore.test.ts src/pages/Connections/ConnectionForm.test.tsxpnpm lintCompile / format / lint UIgit diff --checkThe tests cover the problem statement expectations: preserving
account, avoiding untouchedinsecure_mode, preserving unknown keys, merging changed provider fields, and removing cleared provider fields.Was generative AI tooling used to co-author this PR?
Generated-by: Codex (GPT-5) following the guidelines