UI: Add timetable type filter to Dag list#69728
Open
shivaam wants to merge 1 commit into
Open
Conversation
boring-cyborg
Bot
added
area:API
2 tasks
Users could filter by timetable type through the public API, but the Dag list uses the private UI endpoint. This makes the same capability available from the page users actually use.
shivaam
force-pushed
the
codex/airflow-investigate-issue-53738
branch
from
6218138 to
4841870
Compare
shivaam
requested review from
bbovenzi,
bugraoz93,
choo121600,
ephraimbuddy,
guan404ming,
henry3260,
jason810496,
pierrejeambrun,
rawwar,
ryanahamilton,
shubhamraj-git and
vatsrahul1001
as code owners
potiuk
added
the
ready for maintainer review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds timetable type filtering to the Dag list UI.
The public API already supports filtering Dags by
timetable_type, but the Dag list page uses the private/ui/dagsendpoint. This wires the same filter through the private endpoint, generated UI client, and Dag list filters.closes: #53738
Screenshots / recording: TODO before marking ready for review.
Testing:
uv run pytest airflow-core/tests/unit/api_fastapi/core_api/routes/ui/test_dags.py::TestGetDagRuns::test_timetable_type_filter -qpnpm test src/pages/DagsList/DagsFilters/DagsFilters.test.tsxpnpm exec eslint --quiet src/constants/searchParams.ts src/queries/useDags.tsx src/pages/DagsList/DagsList.tsx src/pages/DagsList/DagsFilters/DagsFilters.tsx src/pages/DagsList/DagsFilters/TimetableTypeFilter.tsx src/pages/DagsList/DagsFilters/DagsFilters.test.tsx src/mocks/handlers/dags.tspnpm exec tsc --p tsconfig.app.jsonprekhooks during commit, including UI compile/lint, OpenAPI generation, mypy, and commit message validation69728.mov
Was generative AI tooling used to co-author this PR?
Generated-by: OpenAI Codex following the guidelines