Preserve AirflowTaskTimeout when timeout logging fails#69713
Open
Andrushika wants to merge 1 commit into
Open
Conversation
…eout When SIGALRM fires in a task-runner whose supervisor pipe is broken, self.log.error inside the signal handler raises BrokenPipeError, which propagates in place of AirflowTaskTimeout. The task then exits with the wrong exception class and skips task_runner's timeout-handling path — visible in the traceback attached to apache#64212 (handle_timeout -> log.error -> structlog _write -> BrokenPipeError, AirflowTaskTimeout absent). Suppress OSError around the log call so a broken pipe at the log sink cannot mask the timeout. OSError matches the evidence in apache#64212 — BrokenPipeError's parent class — without broadening to Exception; whether the scope should be wider is left as an open question for review. Two other links of the same failure chain were already fixed in apache#66572 and apache#67955. Related to apache#64212.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preserve AirflowTaskTimeout when timeout logging fails
Why
handle_timeout()logs a timeout message before raisingAirflowTaskTimeout. The task runtime sends those logs through a pipe handled by the supervisor. If that pipe has been closed (for example, because the supervisor has exited), the logging call can raiseBrokenPipeErrorinstead.This masks the original timeout, causing the task to fail with a logging error rather than
AirflowTaskTimeout. This exact sequence appears in the production traceback in #64212.What
Suppress
OSErrorraised while logging fromhandle_timeout()so a failed log write cannot mask the timeout.handle_timeout()will still raiseAirflowTaskTimeoutafter a logging failure. Non-OSError exceptions from the logging stack are deliberately left out of scope.Was generative AI tooling used to co-author this PR?
Generated-by: Claude Code Opus 4.7 following the guidelines
{pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.