Bump flask-appbuilder to 5.2.2#69706
Open
shahar1 wants to merge 1 commit into
Open
Conversation
Flask-AppBuilder 5.2.2 lifts its Flask-Limiter cap from <4 to <5 and carries security fixes to the security manager that Airflow vendors in override.py. Airflow already carries the LDAP-filter escaping and uuid4 registration-hash fixes, and inherits the OAuth email-whitelist anchoring via super(), so no vendored code needs transplanting. The vendored Flask-Limiter usage in the www security manager relies only on APIs that remain stable across Flask-Limiter 4.x, so lifting the cap introduces no compatibility work.
c31cbd6 to
e6dd4dd
Compare
vincbeck
approved these changes
Jul 10, 2026
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Upgrades Flask-AppBuilder from
5.2.1to5.2.2(latest on PyPI, released 2026-06-23). Follows the same shape as #66841.What 5.2.2 changes and how it maps to Airflow
FAB 5.2.2 carries four security-relevant fixes to the security manager (parts of which Airflow vendors in
override.py) plus a dependency-cap change:<4→<5>3;uv lockkeeps the resolved version at 3.12 (minimal resolution), so this PR does not actually move Flask-Limiter. See compatibility note below._search_ldapoverride.py(Airflow was ahead — it also validates balanced parentheses). No change.add_register_userusesuuid4instead ofuuid1override.py. No change.AuthOAuthView.oauth_authorized, which Airflow'sCustomAuthOAuthViewcalls viasuper(). Inherited automatically. No change.No new public FAB security-manager methods were added, so
test_fab_alignment.pypasses with only theEXPECTED_FAB_VERSIONbump.Flask-Limiter compatibility note
FAB lifting its cap merely unblocks Flask-Limiter 4.x;
uv lockkeeps 3.12. To be safe I verified Airflow's vendored Flask-Limiter usage inproviders/fab/src/airflow/providers/fab/www/security_manager.pyagainst Flask-Limiter 4.1.1:from flask_limiter import Limiterandfrom flask_limiter.util import get_remote_address— both still valid (4.0 prefixed internal submodules with_, bututilremains public).Limiter(key_func=...),limiter.init_app(...), andlimiter.limit(...)with all the kwargs Airflow passes (per_method,methods,error_message,exempt_when,override_defaults,deduct_when,on_breach,cost) — all present in 4.1.1.So even if a future resolution picks Flask-Limiter 4.x, no vendored-code change is required.
Changes
providers/fab/pyproject.toml—flask-appbuilder==5.2.1→==5.2.2providers/fab/tests/unit/fab/auth_manager/security_manager/test_fab_alignment.py—EXPECTED_FAB_VERSION→"5.2.2"uv.lock— re-resolved (flask-appbuilder only; Flask-Limiter stays 3.12)generated/provider_dependencies.json(+.sha256sum),providers/fab/README.rst,providers/fab/docs/index.rst— regenerated by prek (the docs-index regeneration also dropped a stale release-time-only tail block that had drifted onmain)Validation
test_fab_alignment.py— all 7 alignment tests pass withflask-appbuilder==5.2.2installed.providers/fab/tests/unit/fab/auth_manager/security_manager/— all 40 unit tests pass.override.pyand the vendoredwwwsecurity manager import cleanly under FAB 5.2.2.pre-commitprek stage green.Follow-up (not in this PR)
FAB #2468 adds a
log.warningwhen Azure OAuth JWT signature verification is disabled. Airflow's_decode_and_validate_azure_jwtdeliberately deviates from FAB (manual base64 payload decode;verify_signaturedefaults toFalse), and FAB's warning text references FAB's own roadmap ("a future major release will change the default toTrue"), which doesn't fit Airflow's deviation. Whether Airflow should emit its own equivalent warning — arguably more important here since verification is off by default — is a behavioral security change that belongs in a focused change, not this dependency bump.Was generative AI tooling used to co-author this PR?
Generated-by: Claude Code (Opus 4.8) following the guidelines