Fix partition key display and input handling#69702
Open
Lee-W wants to merge 3 commits into
Open
Conversation
Non-partitioned Dag runs showed a dangling "Partition key:" label, an empty partition key typed then cleared was sent to the trigger/materialize APIs and rejected with 400, the trigger form exposed the field even for non-partitioned Dags, the manual asset-event partition key used a JsonEditor for a plain string, and the runs table hid the partition_key column even when its filter was shown for a partitioned Dag. Also unify the partition key label so cron/runtime-partitioned runs no longer say "Mapped Partition key".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The trigger/materialize forms and run views mishandled partition keys — non-partitioned Dag runs showed a dangling "Partition key:" label, an emptied key was sent to the API and rejected with a
400, and the field appeared even where partitioning doesn't apply.What
partition_keyisnull(run header, asset event view)""/undefined) tonullbefore hitting the trigger, materialize, and asset-event APIs — no more400on a blank fieldJsonEditorto a plain textInput— it's a string, not JSONpartition_keycolumn to visible for a partitioned Dag's runs tab, hidden elsewherenon partitioned
partitioned
Was generative AI tooling used to co-author this PR?
{pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.