Improve Playwright test patterns in requiredAction.spec.ts

[Desel72]

Replace Playwright anti-patterns with best practices in requiredAction spec and RequiredActionsPage page object.

Changes in RequiredActionsPage.ts:

• Replace locator('[data-testid="..."]') with getByTestId() (3 occurrences)
• Replace locator("table tbody tr") with role-based getByRole("row")
• Remove waitForTimeout(10_000) arbitrary delay after HITL response

Changes in requiredAction.spec.ts:

• Replace locator('th:has-text("...")') with getByRole("columnheader", { exact: true, name: "..." }) (5 occurrences)
• Replace manual isVisible() boolean assertions with web-first .or() locator pattern

closes: #63432

[choo121600]

@Desel72 This PR has been converted to draft because it does not yet meet our Pull Request quality criteria.

Issues found:

• ❌ Other failing CI checks: Failing: Additional PROD image tests / Chromium UI e2e tests with PROD image / Chromium UI e2e tests, Additional PROD image tests / Firefox UI e2e tests with PROD image / Firefox UI e2e tests, Additional PROD image tests / WebKit UI e2e tests with PROD image / WebKit UI e2e tests. Run prek run --from-ref main locally to reproduce. See static checks docs.

Note: Your branch is 4 commits behind main. Some check failures may be caused by changes in the base branch rather than by your PR. Please rebase your branch and push again to get up-to-date CI results.

What to do next:

• The comment informs you what you need to do.
• Fix each issue, then mark the PR as "Ready for review" in the GitHub UI - but only after making sure that all the issues are fixed.
• Maintainers will then proceed with a normal review.

Converting a PR to draft is not a rejection — it is an invitation to bring the PR up to the project's standards so that maintainer review time is spent productively. If you have questions, feel free to ask on the Airflow Slack.

[choo121600]

It looks like the CI is failing. Could you take a look?

[Desel72]

@choo121600 Sorry for the ping. I’ve tried several times, but the CI tests are still failing. Could you please help me figure out what’s wrong?

[choo121600]

@choo121600 Sorry for the ping. I’ve tried several times, but the CI tests are still failing. Could you please help me figure out what’s wrong?

Hi! It might help to run the test locally first with:

breeze testing ui-e2e-tests --test-pattern "requiredAction.spec.ts" --browser webkit --workers 2

This usually catches most issues. If it still only fails in CI, checking the CI logs might help identify the cause.

[choo121600]

Feel free to ask in the Airflow Slack channel(sig-ui-e2e-tests) as well — you might get a faster response there.

https://apache-airflow.slack.com/archives/C0A2QT7UUGP

[Desel72]

@choo121600 I think the below CI test failure is not related my code change. could you check it?

[Desel72]

Thank you @choo121600 . All CI test passes now. could you merge this?

[choo121600]

It looks like there are still a few places where the checklist or Playwright best practices are not fully followed.
Could you take another look?

[Desel72]

@choo121600 I've updated PR and CI test passes now. could you review again? thank you

[Desel72]

@choo121600 sorry for tagging but when I test locally, it passes all CI test

Could you give me another help? I am really sorry.

[choo121600]

Don't worry. the CI failure here is not related to your code changes.
It was fixed in PR #63890

[Desel72]

@choo121600 Thank you for approving. When will this be merged?

[choo121600]

Let’s wait until the CI turns green :)

[choo121600]

@Desel72 Merged!
Thanks for contribution 🙌