-
Notifications
You must be signed in to change notification settings - Fork 16.5k
chart: add api-server rollout restart cronjob #61636
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
chart: add api-server rollout restart cronjob #61636
Conversation
Add an optional CronJob that runs for the API server deployment, with configurable schedule, target name, and RBAC.
|
Mhm, I am not so for this. Can you give a reason why a periodic restart is needed? Is there a memory leak in the software? Then we should rather fix the root cause and not compensate with a preriodic restart feature. |
Thanks for your feedback!! This isn’t meant to mask a known memory leak. |
Mhm, still not fully convincing. This adds really a lot of complexity for a operational shortcoming that in my view should be fixed in other places. We are planning to carve-out complexity of the chart and this here adds a whole lot of additional complexity. Maybe this is one of the first candidates where we offer a structure to add custom stuff on top via Kustomize? |
Makes sense to me. @jason810496 WDYT? |
|
Thanks Jens for the review!
Do we need to raise discussion in Dev mailing list or Slack channel?
Or if introducing Kustomize had already been decided, then yes, I think it makes sense to me. |
Thanks Jason! |
Why
The new gunicorn server type provides rolling worker restarts, but for users who continue to use the default uvicorn mode on Kubernetes, it’s useful to have a first‑class mechanism in the Helm chart to periodically restart the API server pods.
What
Add an optional CronJob (
runs kubectl rollout restart deployment/airflow-api-server)that runs for the API server deployment, with configurable schedule, target name, and RBAC.closes: #61432
Was generative AI tooling used to co-author this PR?
Copilot
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.