Skip to content

Conversation

@XD-DENG
Copy link
Member

@XD-DENG XD-DENG commented Jan 22, 2026

(Found this issue when I was playing with go-sdk for some inspirations)

The bundle plugin was using viper key 'execution-api-url' but the config file (go-sdk.yaml) uses nested YAML format 'execution.api_url' matching the pattern used by other config sections (edge.api_url, api_auth.secret_key).

This caused the plugin to fail silently when execution.api_url was set in go-sdk.yaml because viper couldn't find the incorrectly-named key (I had to add a line execution-api-url: xxx in go-sdk.yaml as a workaround).

This PR fixes this issue. Also fixed the README.md to use YAML syntax instead of TOML (the doc mentioned it should be a YAML).


Was generative AI tooling used to co-author this PR?
  • Yes (please specify the tool below)

  • Read the Pull Request Guidelines for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
  • For fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
  • When adding dependency, check compliance with the ASF 3rd Party License Policy.
  • For significant user-facing changes create newsfragment: {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

The bundle plugin was using viper key 'execution-api-url' but the
config file uses nested YAML format 'execution.api_url' matching
the pattern used by other config sections (edge.api_url, api_auth.secret_key).

This caused the plugin to fail silently when execution.api_url was
set in go-sdk.yaml because viper couldn't find the incorrectly-named key.

Also fixes README.md to use YAML syntax instead of TOML.
@XD-DENG XD-DENG merged commit 62b550a into apache:main Jan 22, 2026
61 checks passed
@XD-DENG XD-DENG deleted the fix-inconsistent-config-key-go-sdk branch January 22, 2026 18:48
suii2210 pushed a commit to suii2210/airflow that referenced this pull request Jan 26, 2026
The bundle plugin was using viper key 'execution-api-url' but the
config file uses nested YAML format 'execution.api_url' matching
the pattern used by other config sections (edge.api_url, api_auth.secret_key).

This caused the plugin to fail silently when execution.api_url was
set in go-sdk.yaml because viper couldn't find the incorrectly-named key.

Also fixes README.md to use YAML syntax instead of TOML.
shreyas-dev pushed a commit to shreyas-dev/airflow that referenced this pull request Jan 29, 2026
The bundle plugin was using viper key 'execution-api-url' but the
config file uses nested YAML format 'execution.api_url' matching
the pattern used by other config sections (edge.api_url, api_auth.secret_key).

This caused the plugin to fail silently when execution.api_url was
set in go-sdk.yaml because viper couldn't find the incorrectly-named key.

Also fixes README.md to use YAML syntax instead of TOML.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants