Skip to content

Conversation

@XPE-7
Copy link

@XPE-7 XPE-7 commented Jan 21, 2026

Summary

This PR improves the output of breeze ci selective-check when it is executed in CI with --verbose.

When running under CI, a short “HOW TO REPRODUCE LOCALLY” section is printed at the end of the output. This provides a clear and minimal command that can be used to reproduce the same check locally.

The behavior is intentionally scoped to:

  • CI environments (CI=true)
  • Verbose runs (--verbose)

There is no change in behavior for normal local executions.


What changed

  • Added a small reproduction hint that is printed at the end of breeze ci selective-check output when running in CI with --verbose
  • Ensured the message is printed outside any collapsed CI log groups so it is immediately visible
  • Added tests to verify:
    • The reproduction message is shown in CI with verbose enabled
    • The message is not shown without --verbose
    • The message is not shown outside CI

Example output

============================================================
HOW TO REPRODUCE LOCALLY
============================================================

breeze ci selective-check --verbose

@boring-cyborg
Copy link

boring-cyborg bot commented Jan 21, 2026

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our prek-hooks will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@boring-cyborg boring-cyborg bot added area:dev-tools backport-to-v3-1-test Mark PR with this label to backport to v3-1-test branch labels Jan 21, 2026
@potiuk
Copy link
Member

potiuk commented Jan 21, 2026

Can you please explain what's the purpose of it?

I don't think you can reproduce selective check with the command the AI proposed. This only will be reproduced if you pass the right commit-ref, and the one that CI uses is a merge commit resulting from merging the PR to main.

How are you going to reproduce that?

@XPE-7
Copy link
Author

XPE-7 commented Jan 22, 2026

Thanks for the clarification.

You’re right without the merge commit that CI generates, the selective-check result can’t be fully reproduced just by running the printed command locally. The intention here wasn’t to claim a perfect reproduction, but to give contributors a clear entry point to run the same logic locally when CI runs selective-check in verbose mode.

Right now, when this runs in CI, there’s no visible hint on how someone can even start debugging the decision. The command was meant as a baseline, with the understanding that additional inputs (like the merge commit or specific refs) are still needed.

If you think this is misleading without explicitly mentioning the merge commit or passing it through, I’m happy to update the output to make that clear or drop the reproduction message entirely if that’s preferable. Just let me know what you’d recommend.

@XPE-7
Copy link
Author

XPE-7 commented Jan 26, 2026

Any updates @potiuk ??

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:dev-tools backport-to-v3-1-test Mark PR with this label to backport to v3-1-test branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants