Fix flaky test_execution test #60879
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why:
The
test_executiontest is flaky due to a race condition. When the worker raises the intendedRuntimeError, it crashes, causing the LocalExecutor to immediately respawn a new worker to maintain parallelism.This creates an infinite crash-and-respawn loop if the new worker picks up the failing task again. As a result,
executor.end()hangs (times out) because it cannot successfully join the processes while new ones are constantly being spawned.How:
I introduced a
has_failed_onceflag to ensure the worker raises theRuntimeErroronly once. Subsequent executions will return successfully. This prevents the infinite respawn loop, allowing the worker to shut down gracefully andexecutor.end()to finish without timing out.closes: #45329
Was generative AI tooling used to co-author this PR?
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.