Skip to content

Conversation

@arjav1528
Copy link
Contributor

@arjav1528 arjav1528 commented Jan 6, 2026

Description

This PR adds two new React components that restore the task group marking functionality:

  1. MarkGroupTaskInstanceAsButton - A dropdown button component that allows users to select a state (success/failed) and opens a dialog for confirmation
  2. MarkGroupTaskInstanceAsDialog - A dialog component that provides:
    • Options to include past/future/upstream/downstream task instances
    • Dry-run preview showing which task instances will be affected
    • Ability to add notes to the state change
    • Bulk update using the task instance bulk API for efficiency

The button is integrated into the Group Task Instance page header, alongside the existing Clear button.

Screenshots

image image

Solves #60121

@boring-cyborg boring-cyborg bot added the area:UI Related to UI/UX. For Frontend Developers. label Jan 6, 2026
@bohdan-pd
Copy link

@arjav1528 Thank you for working on that! 👍

@arjav1528 arjav1528 force-pushed the main branch 2 times, most recently from 5db3cd8 to c9d177e Compare January 6, 2026 18:50
@arjav1528 arjav1528 marked this pull request as draft January 6, 2026 18:50
@arjav1528 arjav1528 marked this pull request as ready for review January 6, 2026 18:50
@arjav1528
Copy link
Contributor Author

@arjav1528 Thank you for working on that! 👍

is the UI ok or do you want me to refactor that

Copy link
Contributor

@bbovenzi bbovenzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking this on! Do you mind doing more manually testing to find where MarkAs isn't quite working? I think there are some issues with the API that we need to tackle before we can merge any UI changes.

Copy link
Contributor

@bbovenzi bbovenzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried using this locally and still had issues. Could you both manually test this out and also add fastapi test for dry runs?

@arjav1528
Copy link
Contributor Author

I tried using this locally and still had issues. Could you both manually test this out and also add fastapi test for dry runs?

Sorry about the trouble. I’ve tested this locally and couldn’t reproduce the issue. Could you please share a specific failing case or screenshot/log to help narrow this down?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:UI Related to UI/UX. For Frontend Developers.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants