-
Notifications
You must be signed in to change notification settings - Fork 16.3k
Restore ability to mark task groups as success/failed in UI #60161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
@arjav1528 Thank you for working on that! 👍 |
5db3cd8 to
c9d177e
Compare
is the UI ok or do you want me to refactor that |
bbovenzi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking this on! Do you mind doing more manually testing to find where MarkAs isn't quite working? I think there are some issues with the API that we need to tackle before we can merge any UI changes.
...low-core/src/airflow/ui/src/components/MarkAs/TaskInstance/MarkGroupTaskInstanceAsDialog.tsx
Outdated
Show resolved
Hide resolved
...low-core/src/airflow/ui/src/components/MarkAs/TaskInstance/MarkGroupTaskInstanceAsDialog.tsx
Outdated
Show resolved
Hide resolved
providers/snowflake/tests/unit/snowflake/hooks/test_snowflake_sql_api.py
Outdated
Show resolved
Hide resolved
…alog components for task instance state management
…task instance handling
…ces in MarkGroupTaskInstanceAsDialog
…rs to preview changes without affecting state
…oks to ensure correct functionality
…dering and improve dialog behavior
bbovenzi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried using this locally and still had issues. Could you both manually test this out and also add fastapi test for dry runs?
Sorry about the trouble. I’ve tested this locally and couldn’t reproduce the issue. Could you please share a specific failing case or screenshot/log to help narrow this down? |
Description
This PR adds two new React components that restore the task group marking functionality:
MarkGroupTaskInstanceAsButton- A dropdown button component that allows users to select a state (success/failed) and opens a dialog for confirmationMarkGroupTaskInstanceAsDialog- A dialog component that provides:The button is integrated into the Group Task Instance page header, alongside the existing Clear button.
Screenshots
Solves #60121