Repository navigation
Conversation
mattrpav
force-pushed
the
amq-virtual-thread-per-runner
branch
from
November 14, 2026 19:05
7d067d4 to
6c733f4
Compare
…ixes One long-lived virtual thread per TaskRunner that parks between work, replacing the thread per wakeup submission, with termination logged on unexpected errors. No-arg shutdown() waits for the running iteration, matching the pooled and dedicated runners. Client-side fixes: load the java21 classes through this artifact's own class loader so client factories work without setThreadClassLoader, honor the system property in task runner selection the same as in executor setup, create the failover reconnect task on first use so the virtual thread setting reaches it, propagate the connection factory flag to the failover transport, and keep the task runner settings across serialization and JNDI. Tests: task runner behavior (thread identity, wakeup delivery, shutdown bounds and contract, failure logging, thread release) run through both the factory flag and the system property, the client configuration precedence matrix, session dispatch and failover reconnect on both thread types.
mattrpav
force-pushed
the
amq-virtual-thread-per-runner
branch
from
November 14, 2026 19:47
6c733f4 to
62abafa
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
First iteration of Virtual Thread task runner created a VT per-wakeup. This moves to create a VT per-Task and is more inline with how the other runners work. This is specifically shows improvement for fast ack'n non-persistent consumers.
ref: client-side fixes was in previous PR [#2766]