Skip to content

Cleanup BlobTransferpolicy SPI and URL validation - #2767

Open
mattrpav wants to merge 1 commit into
apache:mainfrom
mattrpav:amq-blob-client-api
Open

mattrpav wants to merge 1 commit into
apache:mainfrom
mattrpav:amq-blob-client-api

Conversation

@mattrpav

@mattrpav mattrpav commented Oct 28, 2026 •

Copy link
Copy Markdown
Contributor
  • Add injection point for DownloadStrategy
  • Centralize URL validation
  • Add additional tests

@cshannon

cshannon commented Nov 2, 2026

Copy link
Copy Markdown
Contributor

This PR doesn't make sense to me because we should be deprecating and removing the BLOB support entirely, which I'm pretty sure we had previously discussed but I would have to look.

@mattrpav

mattrpav commented Nov 2, 2026

Copy link
Copy Markdown
Contributor Author

@cshannon I understood that we were looking to remove the FTP Blob support, as that was seen as dated. I know we have users that need large file offload and support for http-based (or scp/sftp) would be valuable and keep ActiveMQ on-par with other messaging solutions.

Happy to take this to the list or a GH discussion as needed.

@mattrpav mattrpav moved this from Backlog to Ready in Apache ActiveMQ v6.5.0 Nov 4, 2026
@mattrpav mattrpav moved this from Ready to In review in Apache ActiveMQ v6.5.0 Nov 4, 2026
@cshannon

cshannon commented Nov 6, 2026

Copy link
Copy Markdown
Contributor

@cshannon I understood that we were looking to remove the FTP Blob support, as that was seen as dated. I know we have users that need large file offload and support for http-based (or scp/sftp) would be valuable and keep ActiveMQ on-par with other messaging solutions.

Happy to take this to the list or a GH discussion as needed.

Yeah it's probably good to start a discussion and see what people think we should support. If we want to keep Blob support I think it needs to be hardened for sure, remove insecure protocols and all of that.

@mattrpav

mattrpav commented Nov 6, 2026 •

Copy link
Copy Markdown
Contributor Author

@cshannon sounds good. I'll bring it up on dev@

edit: [#2805] added to remove FTP blob support in v6.5.0 per dev@ discussion. This PR remains to harden URL processing and validation.

@mattrpav
mattrpav requested a review from cshannon November 9, 2026 16:39
@mattrpav mattrpav changed the title Cleanup BlobTransferpolicy to support new strategies Cleanup BlobTransferpolicy SPI and URL validation Nov 11, 2026
- Add BlobTransferPolicy.setDownloadStrategy
- Delete uses the URL on the message
- Allowed protocols are file and https
- Add org.apache.activemq.blob.AllowedProtocols to replace that list
- A received URL must be under the upload URL path
- The file system strategy stays inside the upload folder
- Add org.apache.activemq.blob.HttpFollowRedirects, default true
- Default upload URL is https://localhost:8080/uploads/
@mattrpav
mattrpav force-pushed the amq-blob-client-api branch from 57e2842 to fec7b26 Compare November 16, 2026 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: In review

Development

Successfully merging this pull request may close these issues.

2 participants