TODO Cleanup

[Amemeda]

• Redact keyExtents in outstanding migrations output to remove TODO in ThrottledBalancerProblemReporter.java. Added this logic onto existing .stream in the logger that logs 10 outstanding migrations.

• Removed outdated TODO from ClientContext.java.

---

Removes 2 TODOs from #2699

[Amemeda]

Adding these comments from the ASF accumulo channel

[DomGarguilo]

Suggested change

	String.join(", ", migrations.stream().limit(10).map(tabletId -> {
	KeyExtent extent = KeyExtent.fromTabletId(tabletId);
	extent.obscured();
	return extent.toString();
	}).map(String::valueOf).collect(Collectors.toSet())));
	migrations.stream()
	.limit(10)
	.map(tabletId -> {
	KeyExtent extent = KeyExtent.fromTabletId(tabletId);
	extent.obscured();
	return extent.toString();
	})
	.collect(Collectors.joining(", "));

I think you can do the join right off the stream so we dont need to collect to a new set. I didnt test this code so the working code might be different

[Amemeda]

if (retryCountDownTimer.isExpired()) {
          // TODO exception used for timeout is inconsistent
          throw new TimedOutException(
              "Failed to find servers to process scans before timeout was exceeded.");
        }

Does anyone know why this exception from TabletServerBatchReaderIterator.java is inconsistent? Is the message inconsistent with what is actually happening?

[dlmarion]

obscured returns the obfuscated String.

Suggested change

	KeyExtent extent = KeyExtent.fromTabletId(tabletId);
	extent.obscured();
	return extent.toString();
	return KeyExtent.fromTabletId(tabletId).obscured();

[dlmarion]

Does anyone know why this exception from TabletServerBatchReaderIterator.java is inconsistent? Is the message inconsistent with what is actually happening?

No idea