More KeywordExecutable changes #6126
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit includes the following changes: * Created BaseKeywordExecutable for code common to Client and ServerKeywordExecutable * Removed ServerUtilOpts, moved ServerContext to ServerKeywordExecutable * Renamed ConfigOpts to ServerOpts * Changed parseArgs method to validateArgs * Fixed up most utilities to either extend ClientKeywordExecutable or ServerKeywordExecutable * Created ServerProcessKeywordExecutable for server processes * Removed main methods where possible
Contributor
Author
|
These changes build on #6104, #6117, #6118, and #6121 to:
This is draft as I need to do some testing to ensure everything is working. The task of renaming and reorganizing the commands is still to be done in another PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit includes the following changes: