Repository navigation
Serve POST /hardware only when explicitly enabled - #22
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
POST /hardwareis now off unlessHARDWARE_ENDPOINT_ENABLED=true. When it is off, the route is not registered, so it answers the standard not found page and nothing reaches Onionoo.Changes
HARDWARE_ENDPOINT_ENABLED:trueorfalse, defaultfalse. Any other value stops the service at startup.startServertakeshardwareEnabled, defaultfalse, and the startup log reports it.trueorfalse.The stage and live jobspecs do not set the variable, so the endpoint is off in both once a build with this change is deployed.
Verified
bun run checkpasses locally: typecheck, 259 pass, 1 skip.