Remove stale node_modules path from CLI installation locations - #1221
Open
anishesg wants to merge 1 commit into
Open
Remove stale node_modules path from CLI installation locations#1221anishesg wants to merge 1 commit into
anishesg wants to merge 1 commit into
Conversation
The `find_installed_cli()` function in `scripts/download_cli.py` included a reference to `Path.home() / "node_modules" / ".bin" / "cli"` as a Unix installation location. This path is not used by the official CLI installer and does not match the installation paths documented in `.github/workflows/test.yml`, which only uses `$HOME/.local/bin` for Linux/macOS and `$USERPROFILE\.local\bin` for Windows. Signed-off-by: anish <anishesg@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
find_installed_cli()function inscripts/download_cli.pyincluded a reference toPath.home() / "node_modules" / ".bin" / "claude"as a Unix installation location. This path is not used by the official Claude CLI installer and does not match the installation paths documented in.github/workflows/test.yml, which only uses$HOME/.local/binfor Linux/macOS and$USERPROFILE\.local\binfor Windows.The node_modules path appears to be a leftover from an earlier installation method that is no longer supported. When the CLI cannot be found during the wheel build process, the error implicitly references this outdated location, causing confusion.
This change removes the stale node_modules reference from the list of checked locations, keeping only the two legitimate Unix installation paths:
$HOME/.local/bin/claudeand/usr/local/bin/claude.Fixes #1194