Raise MessageParseError when a message field is not a dict - #1219
Open
eeshsaxena wants to merge 1 commit into
Open
Raise MessageParseError when a message field is not a dict#1219eeshsaxena wants to merge 1 commit into
eeshsaxena wants to merge 1 commit into
Conversation
…dict parse_message assumes data["message"] is a dict and reads data["message"]["content"], so a message whose "message" field is a string, list, or number raised a raw TypeError instead of the documented MessageParseError. Validate it up front like the content blocks already are.
Author
|
Hi! Gentle nudge on this one whenever you have some bandwidth. It's a small, self-contained fix ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
parse_messagedocuments that it raisesMessageParseErroron bad input, but a user or assistant message whosemessagefield is not a dict leaks a rawTypeError:Both handlers read
data["message"]["content"]assumingmessageis an object, so a string, list, or number there blows up before theexcept KeyErrorcan wrap it. I validatemessageis a dict up front and raiseMessageParseError, the same way the content blocks are already checked (this matches the existingtest_non_dict_content_block_raises_documented_errorcase). Added a parametrized test.