fix(lib): normalise JSON Schema type arrays instead of hitting assert_never (Fixes #1877) - #1880
Open
mukktinaadh wants to merge 1 commit into
Open
fix(lib): normalise JSON Schema type arrays instead of hitting assert_never (Fixes #1877)#1880mukktinaadh wants to merge 1 commit into
mukktinaadh wants to merge 1 commit into
Conversation
…_never (Fixes anthropics#1877) - Convert type arrays (e.g., ["string", "null"]) to anyOf schemas - Add _normalize_type_array helper to validate and convert type arrays - Handle type arrays before anyOf/oneOf/allOf processing - Add validation for type arrays (empty, duplicates, unsupported types) - Includes comprehensive tests for type array handling Fixes anthropics#1877
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes issue #1877 by normalising JSON Schema type arrays (e.g.,
[\"string\", \"null\"]) toanyOfschemas instead of hittingassert_never.Problem
When a JSON Schema uses a type array (e.g.,
{\"type\": [\"string\", \"null\"]}), thetransform_schemafunction would hitassert_never(type_)because it didn't handle type arrays. Type arrays are valid JSON Schema (draft 4 onward) and are commonly produced by tools likezodfor nullable types (z.string().nullable()).Solution
Added a
_normalize_type_arrayhelper that:{\"type\": t}anyOfarrayThe type array handling happens early in the pipeline, before
anyOf/oneOf/allOfprocessing, ensuring the rest of the pipeline can handle it naturally.Changes
_normalize_type_arrayhelper functionanyOf/oneOf/allOfprocessingTesting
Fixes #1877