fix(skills): make setup_skills idempotent and add keep_skills opt-out - #1872
Open
SparshM8 wants to merge 1 commit into
Open
fix(skills): make setup_skills idempotent and add keep_skills opt-out#1872SparshM8 wants to merge 1 commit into
SparshM8 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses the race condition and redundant downloads in
setup_skillsreported in issue #1871.Changes
.versionfile check in_skills.py. If the resolved skill version already exists on disk, the download and extraction are skipped. This prevents concurrent sessions from wiping each other's skill directories when they share a workdir.keep_skillsOption: Added akeep_skills: bool = Falseflag toAgentToolContext. When set toTrue,_cleanup_skillsbecomes a no-op, allowing for persistent worker-level skill caching.Verification
Verified with a reproduction script that simulates concurrent sessions sharing a workdir. Without this fix, the second session would re-download and the first session's exit would delete the skills being used by the second. With this fix, the skills remain intact.
Fixes #1871