fix(credentials): guard fchmod on Windows - #1869
Open
OllieinCanada wants to merge 1 commit into
Open
Conversation
Signed-off-by: Oliver Slapinski <olliefromcanada@gmail.com>
OllieinCanada
marked this pull request as ready for review
August 21, 2026 19:14
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1868
Summary
Guard the POSIX-only
os.fchmodcall when atomically writing credentials soOAuth token refreshes can persist rotated credentials on Windows.
The write path still applies mode
0600wheneverfchmodis available. Onplatforms without it, the existing atomic write, file
fsync, and replacementcontinue normally.
Impact
Previously, the refresh request could succeed and rotate the server-side
refresh token, then Windows would raise
AttributeErrorbefore writing the newtoken. The credentials file retained the now-invalid old token and subsequent
refreshes failed with
invalid_grant.Tests
os.fchmodremovedfchmodis called with0600tests/lib/test_credentials.py: 219 passed, 4 skippedruff check .git diff --checkNo real credentials, API calls, or external services are used by the
regression tests.