feat: Remote rendering 3.1a - add per-part write path to the dataset registry - #50
Merged
Merged
Conversation
LKasianAnsys
force-pushed
the
feat/3.1a-registry-per-part-write-path
branch
from
August 31, 2026 15:29
029c950 to
ff688aa
Compare
LKasianAnsys
marked this pull request as ready for review
August 31, 2026 16:37
margalva
self-requested a review
September 1, 2026 19:51
margalva
approved these changes
Sep 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Addresses #18
Context
This is the first of 5 PRs for user story 3.1 (#18) of the phased implementation plan (here) for adding remote rendering in VISOR.
Per-part visual state (visibility, opacity, diffuse color, color variable), is currently held client-side on
VisorPartStateand reaches the server only viagetAppStateAsyncwhen thesave_stateAPI is called. This story inverts that, makingVisorDatasetRegistrythe source of truth for per-part state by the end of 3.1. This PR is the first step: adding registry-side storage and a write path, with no callers yet. The VTK operations that apply the state land in PR 2, the trigger handlers in PR 3, the client-initiated triggers in PR 4, and save/load state in PR 5.Notes:
get_scene_detailsbuilds its payload from.set_part_visibility,set_part_opacity, etc), if a part record is not found, one is created.Summary
This pull request adds a new per-part write path to the
VisorDatasetRegistry, enabling fine-grained control and mutation of individual part states within datasets at runtime. It introduces a set of methods for getting and setting properties (such as visibility, opacity, color, and selection) on a per-part basis, along with unit tests to ensure correct behavior. The changes also clarify the distinction between name-keyed and id-keyed state management paths.Per-part state management enhancements:
VisorDatasetRegistryfor per-part state mutation and retrieval, includingset_part_visibility,set_part_opacity,set_part_diffuse_color,set_part_selected,set_part_color_variable,clear_part_color_variable, andreplace_part_states. These methods allow direct manipulation of runtime state for individual parts, with robust handling for unknown part IDs and upsert logic for missing state records.find_dataset_id_for_partandget_part_statemethods to locate the owning dataset for a part and retrieve its current state, supporting the new per-part write path.Tests:
make_part_datasethelper for building test datasets with real runtime state. [1] [2]