Skip to content

chore: Bump trame_vtklocal to 1.6.2 - #147

Open
ansBAkula wants to merge 6 commits into
mainfrom
feat/wasm_assets
Open

ansBAkula wants to merge 6 commits into
mainfrom
feat/wasm_assets

Conversation

@ansBAkula

@ansBAkula ansBAkula commented Sep 28, 2026 •

Copy link
Copy Markdown
Collaborator

This branch bumps trame-vtklocal from 0.16.4 to 1.6.2 and updates the code that depends on its WASM asset layout to match the new version's behavior.

  • Dependency bump: trame-vtklocal pinned version updated from 0.16.4 to 1.6.2 in pyproject.toml.
  • Why: the new version changed how it ships and exposes its WASM assets, so downstream code had to change to keep working.
  • Old behavior (0.16.4): shipped a single flat WASM directory under wasm/<version>, and exposed its URL to the frontend as a plain string under the __trame_vtklocal_wasm_url state key.
  • New behavior (1.6.2): builds separate 32-bit and 64-bit WASM variants under wasm32/<version> and wasm64/<version>, and exposes them to the frontend as objects (with a url property) under new state keys — __trame_vtklocal_wasm32 / __trame_vtklocal_wasm64.
  • autosetup.py: updated to copy the wasm32 build instead of the old flat wasm directory. The wasm32 (non-threaded) variant was chosen because it doesn't require crossOriginIsolated.
  • RemoteVtkScene.js: updated to probe several possible state keys and handle both the old plain-string format and the new object format when resolving the WASM asset URL, so the client keeps working regardless of which trame_vtklocal version is installed.

Addresses #126

@ansBAkula
ansBAkula requested a review from margalva as a code owner September 28, 2026 04:40
@github-actions github-actions Bot added maintenance Operation not directly changing the production code - e.g., updating a devops pipeline added enhancement New feature or request labels Sep 28, 2026
@github-actions github-actions Bot added the test Work associated with testing label Sep 28, 2026
@ansBAkula
ansBAkula marked this pull request as draft September 28, 2026 05:38
@ansBAkula
ansBAkula marked this pull request as ready for review September 28, 2026 11:01
@ansBAkula ansBAkula changed the title feat: wasm assets chore: Bump trame_vtklocal to 1.6.2 Sep 28, 2026
@margalva

Copy link
Copy Markdown
Collaborator

@ansBAkula can you please add in the description info about the code changes in this PR as well? The current description indicates only the library bump, but there actually is more work there (for the WASM library fix). Can you please add in the PR description what these changes are and how they change the behavior of VISOR?
Thanks.

@ansBAkula

Copy link
Copy Markdown
Collaborator Author

@ansBAkula can you please add in the description info about the code changes in this PR as well? The current description indicates only the library bump, but there actually is more work there (for the WASM library fix). Can you please add in the PR description what these changes are and how they change the behavior of VISOR? Thanks.

Done.

@LKasianAnsys LKasianAnsys left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Built in a clean repo (including the updated visor-setup), ran some basic manual tests, and didn't see any issues. Approving (though I know @margalva needs to approve as well)

Comment thread src/ansys/visor/visor-client/src/wasm/RemoteVtkScene.js

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

added enhancement New feature or request maintenance Operation not directly changing the production code - e.g., updating a devops pipeline test Work associated with testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants