Repository navigation
fix(desktop): ⌘R reloads the focused browser tab - #57550
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With focus in the side-panel browser, ⌘R reloaded the whole OpenCode window. The page view left ⌘R to the page (#56697 deliberately didn't claim it), so it fell through to the View menu's Reload role, which reloads the window.
before-input-eventnow claims ⌘R (Ctrl+R off macOS) alongside F5 and reloads that page. Claiming the chord also blocks the menu accelerator.mod+rcommand scoped to#browser-panelreloads the tab, like the existing scoped ⌘W, ⌘T and ⌘L commands.Tests: a
pageReloadtable inkeys.test.ts, and a component story inbrowser-pane-restore.spec.ts(⌘R in the address bar reloads the tab, and outside the pane it stays unhandled for the window).