fix(core): preserve activated venv/conda env in spawned shells#38817
Open
freerainboxbox wants to merge 1 commit into
Open
fix(core): preserve activated venv/conda env in spawned shells#38817freerainboxbox wants to merge 1 commit into
freerainboxbox wants to merge 1 commit into
Conversation
Contributor
|
The following comment was made by an LLM, it may be inaccurate: The search found two potentially related PRs that deal with shell environment handling:
However, neither of these appears to be a direct duplicate of PR #38817, which specifically addresses preserving activated venv/conda environments in spawned shells (issue #37703). The related PRs handle different aspects of environment management (WSL and agent markers respectively). No duplicate PRs found |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #37703
Type of change
What does this PR do?
The previous issue reported that
opencode's agents and direct shell calls did not inherit the invoking shell's virtual environment, if one was present. This PR fixes this problem, relevant only for macOS and Linux systems. Windows is out of scope and no fixes were necessary.How did you verify your code works?
New tests in shell.test.ts, shell-env.test.ts. All tests passing and zero regressions.
Verified functionality manually on all relevant POSIX shells.
Verified functionality on dev build of desktop app.
Observe in screenshots section that
pythonresolves to correct location corresponding to parent shell's virtual environment.Screenshots / recordings
Checklist