Skip to content

fix(core): preserve reasoning metadata on errored assistant turns #38763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
loulanyue wants to merge 1 commit into
base: dev
Choose a base branch
from
+7 −3
Open

fix(core): preserve reasoning metadata on errored assistant turns #38763

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/core/src/session/runner/to-llm-message.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ const assistant = (message: SessionMessage.Assistant, model: Model) => {
{
type: "reasoning",
text: item.text,
providerMetadata: reuseProviderMetadata ? item.providerMetadata : undefined,
providerMetadata: item.providerMetadata,
},
]
: item.text.length > 0
Expand Down
8 changes: 6 additions & 2 deletions packages/core/test/session-runner-message.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -327,7 +327,7 @@ Recent work
])
})

test("drops provider-native continuation metadata from failed assistant turns", () => {
test("drops provider-native continuation metadata from failed assistant turn tools, but preserves reasoning", () => {
const messages = toLLMMessages(
[
SessionMessage.Assistant.make({
Expand Down Expand Up @@ -370,7 +370,11 @@ Recent work
)

expect(messages[0]?.content).toEqual([
{ type: "reasoning", text: "Partial thought", providerMetadata: undefined },
{
type: "reasoning",
text: "Partial thought",
providerMetadata: { openai: { itemId: "rs_failed", reasoningEncryptedContent: null } },
},
{
type: "tool-call",
id: "hosted-failed",
Expand Down
Loading