fix(core): isolate invalid plugin tools during materialize#37934
Closed
BrightonXX wants to merge 8 commits into
Closed
fix(core): isolate invalid plugin tools during materialize#37934BrightonXX wants to merge 8 commits into
BrightonXX wants to merge 8 commits into
Conversation
added 2 commits
July 20, 2026 21:14
…#35963) A plugin could register a structurally invalid tool (missing description, undecodable input schema, opaque object from a different module copy) that only failed when its definition was read inside `materialize()`. The throw broke every subsequent model step in the Location because no definition list could be produced - existing and newly created sessions all failed with `TypeError: Invalid Tool value`, and the bad plugin stayed listed as active because registration itself never validated the runtime. Build each tool definition defensively: wrap the call in try/catch, log a warning with the offending tool name and error, drop the registration so later materializations and settle() do not surface it as a usable tool, and keep the rest of the catalog intact. Settling a dropped tool now returns the normal `Unknown tool: <name>` error path instead of re-throwing. Adds a regression test that registers one good tool and one broken tool (constructed without an `input` schema so `inputJsonSchema(tool.input)` throws) and asserts materialize() returns only the good definition, that the broken tool settle path returns `Unknown tool`, and that the good tool still executes. Fixes anomalyco#35963
github-actions
Bot
added
needs:compliance
Contributor
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
github-actions
Bot
removed
the
needs:compliance
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
1 similar comment
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
Author
|
@github-actions recheck issue |
github-actions
Bot
added
the
needs:compliance
github-actions
Bot
removed
the
needs:compliance
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #35963
Type of change
What does this PR do?
A structurally invalid plugin tool (missing description, undecodable schema, opaque object from a different module copy) throws inside
materialize()and breaks every subsequent model step in the Location because no definition list can be produced.materialize()now wraps eachdefinition()call in try/catch. On failure: log a warning with the tool name and error, drop the registration from thedirectmap so latersettle()calls do not surface it as usable, and continue building the rest of the catalog. The dropped tool settles asUnknown tool: <name>instead of re-throwing.How did you verify your code works?
Reverse verification: reverting
packages/core/src/tool/registry.tsmakes the new test fail withTypeError: Cannot read properties of undefined (reading '~context')from insidematerialize().Screenshots / recordings
Not applicable — this is a core logic change, not a UI change.
Checklist