Skip to content

fix(app): restore model variant accessibility#37857

Merged
Hona merged 1 commit into
devfrom
e2e-titlebar
Jul 20, 2026
Merged

fix(app): restore model variant accessibility#37857
Hona merged 1 commit into
devfrom
e2e-titlebar

Conversation

@opencode-agent

Copy link
Copy Markdown
Contributor

Summary

  • restore an accessible name on configured prompt selectors after the keybind tooltip change removed the title attribute
  • update the thinking-level E2E test to locate the variant selector by role and accessible name

Root cause

PR #37824 moved the selector label from title into a tooltip, but the E2E test still queried button[title="Choose model variant"]. This failed deterministically on Linux and Windows.

Checks

  • bun typecheck (packages/app)
  • bun typecheck (packages/session-ui)
  • confirmed the original failure in CI run 29714821533 and its Playwright artifacts

Requested by: @rekram1-node (Aiden Cline via Slack)

@Hona
Hona enabled auto-merge (squash) July 20, 2026 05:10
@Hona
Hona merged commit 5586f96 into dev Jul 20, 2026
12 checks passed
@Hona
Hona deleted the e2e-titlebar branch July 20, 2026 05:20
@onelpawarai

Copy link
Copy Markdown

Please support me with my ZYRAXON-AI project. https://github.com/onelpawarai/ZYRAXON-AI.git

avion23 pushed a commit to avion23/opencode that referenced this pull request Jul 20, 2026
Co-authored-by: Aiden Cline <rekram1-node@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants