fix(ai): tolerate empty-string tool call id/name in streaming deltas#37783
Closed
Garfier wants to merge 1 commit into
Closed
fix(ai): tolerate empty-string tool call id/name in streaming deltas#37783Garfier wants to merge 1 commit into
Garfier wants to merge 1 commit into
Conversation
Some OpenAI-compatible APIs (e.g. DashScope token-plan / GLM-5.2) send empty strings for id and function.name on subsequent tool call deltas instead of omitting them or sending null. The nullish coalescing operator (??) does not treat empty strings as absent, causing appendOrStart to fail with 'tool call delta is missing id or name'. Treat empty strings as absent so the accumulated identity from the first delta is preserved.
Contributor
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
Contributor
|
This PR doesn't fully meet our contributing guidelines and PR template. What needs to be fixed:
Please edit this PR description to address the above within 2 hours, or it will be automatically closed. If you believe this was flagged incorrectly, please let a maintainer know. |
Contributor
|
This pull request has been automatically closed because it was not updated to meet our contributing guidelines within the 2-hour window. Feel free to open a new pull request that follows our guidelines. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Some OpenAI-compatible APIs (e.g. DashScope token-plan / GLM-5.2) send empty strings for
idandfunction.nameon subsequent tool call deltas instead of omitting them or sendingnull:ToolStream.appendOrStartuses??(nullish coalescing) to fall back to accumulated values, but""is notnull/undefinedso the fallback never triggers. The subsequent!idcheck (!""→true) then fails with:Fix
Treat empty strings as absent in
appendOrStartso the accumulated identity from the first delta is preserved:Testing
Added test case
"tolerates empty-string id and name on subsequent deltas"simulating the DashScope token-plan streaming format. All 8 tests pass.Verified against the real token-plan API (
token-plan.cn-beijing.maas.aliyuncs.com) with GLM-5.2.