fix(opencode): terminate local MCP process trees#37731
Open
flowluap wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #26714
Related to #30123. This fixes the in-process POSIX teardown paths; complete Windows tree containment still requires a Job Object or equivalent.
Type of change
What does this PR do?
SDK client close stops the direct MCP process but may leave descendants alive. This routes disconnect, replacement, failed setup, and instance disposal through one cleanup path. On POSIX it snapshots descendants, sends SIGTERM leaf-first, waits 500 ms, escalates survivors, closes the transport, and verifies the process set again.
How did you verify your code works?
Screenshots / recordings
N/A
Checklist