fix(app): prevent notification crash on unavailable server#37730
Open
water-boom wants to merge 3 commits into
Open
fix(app): prevent notification crash on unavailable server#37730water-boom wants to merge 3 commits into
water-boom wants to merge 3 commits into
Conversation
Contributor
|
The following comment was made by an LLM, it may be inaccurate: Found potential duplicate PRs:
These two PRs appear to be addressing the same or closely related notification crash issues when servers are unavailable. You should verify whether they handle the same root cause and coordinate with any existing work on this issue. |
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #35686
Type of change
What does this PR do?
A persisted active server key can outlive its connection, for example after a
WSL distribution is removed. The notification context then throws during
render and the desktop app can enter a startup crash loop.
This change handles both cases:
activeServer()falls back to it instead ofkeeping the stale key.
ensure()returns an empty notification stateinstead of throwing. The UI remains usable and can recover when a server
becomes available.
How did you verify your code works?
bun typecheckScreenshots / recordings
Not applicable; this does not change the UI.
Checklist