chore: Update fff to 0.9.4#31583
Merged
Merged
Conversation
Contributor
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
e1aca08 to
80df230
Compare
Fixed bun --compile binary embedding
80df230 to
85a3c07
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #31584
Type of change
What does this PR do?
Bumps
@ff-labs/fff-bunfrom 0.9.3 to 0.9.4 and wires up the new embedded-lib resolution it introduces.0.9.4 embeds its native library into
bun build --compileoutput via atype: "file"import plus a build-timeFFF_LIBCconstant (gnu/musl), since libc cannot be detected at build time on Linux. When the define is missing, the embedded resolver falls back tognu, so musl Linux binaries would embed the wrong.so. This PR:FFF_LIBCviabun build --definefor Linux targets in both binary build scripts that bundle fff:packages/opencode/script/build.tsandpackages/cli/script/build.ts, mirroring the existingOPENCODE_LIBC/OPENTUI_LIBChandling (defaults tognu,muslfor the abi-specific builds).declare globalforFFF_LIBCnext to the fff wrapper so type checking of the package'sembedded.tsresolves the constant when consumed from source.How did you verify your code works?
bun typecheckpasses for bothopencodeandcli(previously failed withCannot find name 'FFF_LIBC').packages/opencodeandpackages/core(glob, grep, read, filesystem search) — all pass.opencodeandcli(build.ts --single) and confirmed the fff native lib is embedded (/$bunfs/root/libfff_c-*.dylib) and loads at runtime:opencode debug file searchreturns correct results from the compiled binary.Checklist