Skip to content

fix(core): allow home fff picker #31556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rexdotsh wants to merge 1 commit into
base: dev
Choose a base branch
from
+5 −4
Open

fix(core): allow home fff picker #31556

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions packages/core/src/filesystem/search.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import path from "path"
import os from "os"
import { Context, Deferred, Effect, Layer, Option, Stream } from "effect"
import type { PlatformError } from "effect/PlatformError"
import { FSUtil } from "../fs-util"
Expand Down Expand Up @@ -208,6 +209,7 @@ export const layer: Layer.Layer<Service, never, FSUtil.Service | Ripgrep.Service
wait: new Map<string, Deferred.Deferred<Picker, Error>>(),
recent: [] as Query[],
}
const home = FSUtil.resolve(os.homedir())

yield* fs.ensureDir(root).pipe(Effect.ignore)
yield* Effect.addFinalizer(() =>
Expand Down Expand Up @@ -278,10 +280,9 @@ export const layer: Layer.Layer<Service, never, FSUtil.Service | Ripgrep.Service
frecencyDbPath: path.join(root, `${id}.frecency.mdb`),
historyDbPath: path.join(root, `${id}.history.mdb`),
aiMode: true,
// only the first toolcall picker can accumulate resources to index
// home directory, if the user specifically opened opencode at the
// $HOME level or asked it to search there on purpose, otherwise fallback
enableHomeDirScanning: isFirstPicker,
// FFF rejects home scanning unless opted in. Preserve the existing
// first-picker opt-in and also allow explicit $HOME picker requests.
enableHomeDirScanning: dir === home || isFirstPicker,
// on unix system it is 99.9% that you do not need to search for the
// content at the / so make fff fail creation and fallback to rg
enableFsRootScanning: isFirstPicker && process.platform === "win32",
Expand Down
Loading