fix(opencode): ensure tool_use/tool_result integrity and Anthropic user-first ordering#31547
Open
TeddyEngel wants to merge 1 commit into
Open
fix(opencode): ensure tool_use/tool_result integrity and Anthropic user-first ordering#31547TeddyEngel wants to merge 1 commit into
TeddyEngel wants to merge 1 commit into
Conversation
Collaborator
|
believe this has previously been fixed elsewhere actually, unless u can send me a session where u hit it |
Author
|
@rekram1-node it's unfortunately still an issue. Here is a redacted session that crashes on latest dev, resumes ok with my fix: crash_minimal.json |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #27594
Type of change
What does this PR do?
(The PR implements fix 4 from the linked issue: "A defensive pass that pairs every
tool_usewith the matchingtool_resultbefore dispatch.")Sessions that had undergone nested compaction would fail to resume. The specific error encountered was from Anthropic:
Two issues were identified:
Orphan Tool-Calls (All Providers)
After nested compaction, tool-calls could become orphaned (no corresponding tool-result). Most LLM APIs reject this.
User-First Ordering (Anthropic Only)
After nested compaction, the message array could start with system messages followed directly by an assistant message. Anthropic requires the first non-system message to be
user:How did you verify your code works?
Checklist
If you do not follow this template your PR will be automatically rejected.