fix(core): surface NamedError detail without doubling the tag#31408
Closed
albertdbio wants to merge 2 commits into
Closed
fix(core): surface NamedError detail without doubling the tag#31408albertdbio wants to merge 2 commits into
albertdbio wants to merge 2 commits into
Conversation
Contributor
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
github-actions
Bot
added
needs:compliance
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
The NamedError constructor called super(name), so every instance had Error.message === Error.name. Cause.pretty and Error.prototype.toString() compose an error as name: message, so this produced ProviderAuthError: ProviderAuthError and hid the real data.message. Keep Error.message as the human detail (data.message when present, else empty); the tag stays on .name and renderers compose it. Adds a regression test covering both render paths.
Author
|
Superseded by #31564 — same fix, but opened from a dedicated feature branch ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #31414
Type of change
What does this PR do?
NamedError's constructor calledsuper(name), so every instance hadError.message === Error.name. SinceCause.prettyandError.prototype.toString()render an error as${name}: ${message}, this produced output likeProviderAuthError: ProviderAuthErrorand hid the actualdata.message.This sets
Error.messageto the human detail —data.messagewhen the data carries a stringmessage, otherwise empty — and keeps the tag on.name. Renderers then composeProviderAuthError: <real message>once: no doubled tag, and the detail is no longer hidden.How did you verify your code works?
Added
packages/core/test/util-error.test.tscovering both paths: an error with amessagerenders as"Name: message"via bothtoString()andCause.pretty; one without renders as"Name"(no trailing colon, no doubled tag).bun testpasses locally andbun typecheckis clean across all packages.Screenshots / recordings
N/A — not a UI change.
Checklist