Skip to content

fix: filter LSP diagnostics by client root #16365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dotuananh0712 wants to merge 2 commits into from
+4 −1
Closed

fix: filter LSP diagnostics by client root #16365

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1b202aa
fix: filter LSP diagnostics by client root
dotuananh0712 Mar 6, 2026
c600d7b
Merge branch 'dev' into fix/16353-lsp-diagnostics-leak
dotuananh0712 Mar 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion packages/opencode/src/lsp/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -290,8 +290,11 @@ export namespace LSP {

export async function diagnostics() {
const results: Record<string, LSPClient.Diagnostic[]> = {}
for (const result of await runAll(async (client) => client.diagnostics)) {
const clients = await state().then((x) => x.clients)
for (const client of clients) {
const result = await client.diagnostics
for (const [path, diagnostics] of result.entries()) {
if (!path.startsWith(client.root)) continue
const arr = results[path] || []
arr.push(...diagnostics)
results[path] = arr
Expand Down
Loading