fix(web): update oc_locale cookie on language change#16279
Open
Seungjun0906 wants to merge 2 commits intoanomalyco:devfrom
Open
fix(web): update oc_locale cookie on language change#16279Seungjun0906 wants to merge 2 commits intoanomalyco:devfrom
Seungjun0906 wants to merge 2 commits intoanomalyco:devfrom
Conversation
github-actions
bot
added
contributor
needs:compliance
Contributor
|
The following comment was made by an LLM, it may be inaccurate: Potential Related PR Found:
Why it might be related: |
github-actions
bot
removed
the
needs:compliance
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #16278
Type of change
What does this PR do?
This PR fixes a bug where the language selection fails to persist when switching back to English from a localized page (e.g.,
/docs/ko/).The Problem:
The [middleware.ts] uses an
oc_localecookie to handle redirects at the root path (/docs/). When "English" is selected from the footer, Starlight navigates to/docs/but doesn't update the cookie. The middleware then sees the old locale (e.g.,ko) and redirects the user back to the localized page.The Fix:
Added a client-side script to [Footer.astro] that listens for changes in the
LanguageSelectcomponent. It manually updates theoc_localecookie to the selected language before navigation occurs. This ensures the middleware recognizes the user's manual choice, even when navigating to the root path.How did you verify your code works?
bun dev./docs/ko/./docs/(English) and doesn't redirect back to/docs/ko/.oc_localecookie is updated toenin the browser dev tools.Screenshots / recordings
screen-capture.webm
Checklist