Optimize Marquee Animation with Focus Detection#11
Open
TaewookKwak wants to merge 1 commit intoanimate-react-native:mainfrom
Open
Optimize Marquee Animation with Focus Detection#11TaewookKwak wants to merge 1 commit intoanimate-react-native:mainfrom
TaewookKwak wants to merge 1 commit intoanimate-react-native:mainfrom
Conversation
|
Stopping animation when screen is not in focus to improve performance is neat trick. Also:
|
AjayLSojitra
approved these changes
May 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces an optimization for the Marquee component by pausing the animation when the screen is not visible. Using the useFocusEffect hook from @react-navigation/native, the component now deactivates the frame callback and resets the animation state when the user navigates away. This enhancement reduces unnecessary work on both the UI and JS threads, ultimately improving performance and responsiveness.
Key Changes
Focus Detection & Animation Control:
Activation on Focus: When the screen is active, the frame callback is enabled to run the marquee animation.
Deactivation on Blur: When the screen loses focus, the frame callback is deactivated, and the animation value is reset to zero. This effectively stops the animation and minimizes CPU load.
Performance Optimization:
By pausing the animation on non-visible screens, we reduce redundant rendering and processing, leading to improved performance, especially in scenarios with limited resources.
Backward Compatibility:
The changes are fully backward compatible. Existing usage of the Marquee component will benefit from this optimization without any modifications required from the consumer’s side.
Testing & Validation
Smooth Resume: Verified that the marquee animation resumes correctly when the screen regains focus.
Resource Usage: Confirmed that the UI and JS threads experience reduced load when the animation is paused, enhancing overall app performance.
Conclusion
This enhancement optimizes the Marquee component by ensuring that animations only run when necessary. It contributes to better resource management and smoother performance, particularly in multi-screen applications using @react-navigation/native. Feedback and further improvements are welcome!