Unit abbreviations cache unit info overload#1651
Open
bdbonazz wants to merge 2 commits intoangularsen:masterfrom
Open
Unit abbreviations cache unit info overload#1651bdbonazz wants to merge 2 commits intoangularsen:masterfrom
bdbonazz wants to merge 2 commits intoangularsen:masterfrom
Conversation
Added UnitInfo overload of MapUnitToAbbreviation, MapUnitToDefaultAbbreviation, GetDefaultAbbreviation and GetUnitAbbreviations
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added method overloading to MapUnitToAbbreviation, MapUnitToDefaultAbbreviation, GetDefaultAbbreviation and GetUnitAbbreviations as discussed in this issue.
If, following lipchev's comment, you think this isn't a good idea, please discard this request.