refactor(aria/toolbar): remove selection behavior - #33747
Open
ok7sai wants to merge 1 commit into
Open
Conversation
ok7sai
force-pushed
the
refactor/toolbar-remove-selection
branch
from
August 28, 2026 23:31
266db1f to
3ddd157
Compare
ok7sai
marked this pull request as ready for review
September 1, 2026 17:51
crisbeto
approved these changes
Sep 1, 2026
crisbeto
left a comment
crisbeto
left a comment
Member
There was a problem hiding this comment.
LGTM. Do we need to update ADEV as well?
Member
Author
Yes we have to. I can update ADEV examples first to decouple the selection to be safe. |
ok7sai
added
action: merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removing selection behavior so Toolbar no longer listen to
EnterandSpaceevents.Fixes #33684