Repository navigation
feat(@angular/build): add manualRebuild option to the dev-server
#34742
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
DingWeizhe
wants to merge
4
commits into
angular:main
from
DingWeizhe:feat/dev-server-manual-rebuild
Closed
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
b0358d8
feat(@angular/build): add `manualRebuild` option to the dev-server
6d53062
feat(@angular/cli): add `devserver_rebuild` MCP tool
4c331ae
fixup! feat(@angular/build): add `manualRebuild` option to the dev-se…
79749d0
fixup! feat(@angular/cli): add `devserver_rebuild` MCP tool
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
94 changes: 94 additions & 0 deletions
94
packages/angular/build/src/builders/dev-server/tests/options/manual-rebuild_spec.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,94 @@ | ||
| /** | ||
| * @license | ||
| * Copyright Google LLC All Rights Reserved. | ||
| * | ||
| * Use of this source code is governed by an MIT-style license that can be | ||
| * found in the LICENSE file at https://angular.dev/license | ||
| */ | ||
|
|
||
| import { setTimeout } from 'node:timers/promises'; | ||
| import { executeDevServer } from '../../index'; | ||
| import { describeServeBuilder } from '../jasmine-helpers'; | ||
| import { BASE_OPTIONS, DEV_SERVER_BUILDER_INFO } from '../setup'; | ||
|
|
||
| const REBUILD_PATH = '__ng_rebuild'; | ||
|
|
||
| describeServeBuilder(executeDevServer, DEV_SERVER_BUILDER_INFO, (harness, setupTarget) => { | ||
| describe('Option: "manualRebuild"', () => { | ||
| beforeEach(() => { | ||
| setupTarget(harness); | ||
| }); | ||
|
|
||
| it('only rebuilds file changes when a rebuild is requested', async () => { | ||
| harness.useTarget('serve', { | ||
| ...BASE_OPTIONS, | ||
| watch: true, | ||
| manualRebuild: true, | ||
| }); | ||
|
|
||
| let baseUrl = ''; | ||
| let rebuildResponse: Promise<Response> | undefined; | ||
|
|
||
| await harness.executeWithCases([ | ||
| async ({ result }) => { | ||
| expect(result?.success).toBeTrue(); | ||
| baseUrl = result?.baseUrl as string; | ||
|
|
||
| // Nothing pending so a request should not rebuild | ||
| const noChangesResponse = await fetch(new URL(REBUILD_PATH, baseUrl), { | ||
| method: 'POST', | ||
| }); | ||
| expect(noChangesResponse.status).toBe(200); | ||
| expect(await noChangesResponse.json()).toEqual({ status: 'no-changes' }); | ||
|
|
||
| await harness.modifyFile( | ||
| 'src/main.ts', | ||
| (content) => content + 'console.log("abcd1234");', | ||
| ); | ||
|
|
||
| // Give the file watcher enough time to detect the change. No rebuild should occur. | ||
| await setTimeout(1500); | ||
| const before = await fetch(new URL('main.js', baseUrl)); | ||
| expect(await before.text()).not.toContain('abcd1234'); | ||
|
|
||
| // Request a rebuild. The response is sent once the rebuild completes. | ||
| rebuildResponse = fetch(new URL(REBUILD_PATH, baseUrl), { method: 'POST' }); | ||
| }, | ||
| async ({ result }) => { | ||
| expect(result?.success).toBeTrue(); | ||
|
|
||
| const response = await rebuildResponse; | ||
| expect(response?.status).toBe(200); | ||
| expect(await response?.json()).toEqual({ status: 'success' }); | ||
|
|
||
| const after = await fetch(new URL('main.js', baseUrl)); | ||
| expect(await after.text()).toContain('abcd1234'); | ||
| }, | ||
| ]); | ||
| }); | ||
|
|
||
| it('rejects non-POST and cross-origin rebuild requests', async () => { | ||
| harness.useTarget('serve', { | ||
| ...BASE_OPTIONS, | ||
| watch: true, | ||
| manualRebuild: true, | ||
| }); | ||
|
|
||
| await harness.executeWithCases([ | ||
| async ({ result }) => { | ||
| expect(result?.success).toBeTrue(); | ||
| const url = new URL(REBUILD_PATH, result?.baseUrl as string); | ||
|
|
||
| const getResponse = await fetch(url); | ||
| expect(getResponse.status).toBe(405); | ||
|
|
||
| const crossOriginResponse = await fetch(url, { | ||
| method: 'POST', | ||
| headers: { origin: 'http://example.com' }, | ||
| }); | ||
| expect(crossOriginResponse.status).toBe(403); | ||
| }, | ||
| ]); | ||
| }); | ||
| }); | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.