Skip to content

fix(@angular/build): normalize resource paths for diagnostic cache - #34733

Closed
Matt-code-d wants to merge 1 commit into
angular:mainfrom
Matt-code-d:fix/normalize-resource-deps-modified-files
Closed

Matt-code-d wants to merge 1 commit into
angular:mainfrom
Matt-code-d:fix/normalize-resource-deps-modified-files

Conversation

@Matt-code-d

Copy link
Copy Markdown

Fixes #34725

On Windows, modifiedFiles uses native separators from path.normalize, while getResourceDependencies() still returns POSIX paths, so the diagnostic cache is not cleared for template-only edits.

Same normalize() approach as elsewhere in this package. Checked on win32 with the issue repro (NG5002 / NG8106).

@google-cla

google-cla Bot commented Nov 16, 2026

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the AOT compilation process in Angular build tools by importing and applying the 'normalize' function from 'node:path' to resource dependencies before checking if they exist in 'hostOptions.modifiedFiles'. This ensures consistent path formatting when tracking modified resource files. There are no review comments, and I have no feedback to provide.

@Matt-code-d

Copy link
Copy Markdown
Author

I've signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Template diagnostics not updated in watch mode on Windows when the type-check block is unchanged

1 participant