Repository navigation
fix(@angular/build): normalize resource paths for diagnostic cache - #34733
Matt-code-d wants to merge 1 commit into
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
There was a problem hiding this comment.
Code Review
This pull request updates the AOT compilation process in Angular build tools by importing and applying the 'normalize' function from 'node:path' to resource dependencies before checking if they exist in 'hostOptions.modifiedFiles'. This ensures consistent path formatting when tracking modified resource files. There are no review comments, and I have no feedback to provide.
|
I've signed the CLA. |
Fixes #34725
On Windows,
modifiedFilesuses native separators frompath.normalize, whilegetResourceDependencies()still returns POSIX paths, so the diagnostic cache is not cleared for template-only edits.Same
normalize()approach as elsewhere in this package. Checked on win32 with the issue repro (NG5002 / NG8106).