Skip to content

refactor(@angular-devkit/core): stop using PartiallyOrderedSet internally - #34729

Merged
clydin merged 1 commit into
angular:mainfrom
clydin:refactor/remove-internal-partially-ordered-set
Nov 16, 2026
Merged

clydin merged 1 commit into
angular:mainfrom
clydin:refactor/remove-internal-partially-ordered-set

Conversation

@clydin

@clydin clydin commented Nov 16, 2026

Copy link
Copy Markdown
Member

CoreSchemaRegistry was the only internal consumer of the deprecated PartiallyOrderedSet class. Replacing its _pre and _post fields with plain arrays and a small addTransform helper removes that dependency while preserving insertion order, deduplication, and support for the deprecated deps parameter.

To avoid importing partially-ordered-set.ts for its error types as well, DependencyNotFoundException and CircularDependencyFoundException have been moved to exception.ts so they remain exported from the package root after the deprecated file is eventually removed.

…ally

CoreSchemaRegistry was the only internal consumer of the deprecated PartiallyOrderedSet class. Replacing its _pre and _post fields with plain arrays and a small addTransform helper removes that dependency while preserving insertion order, deduplication, and support for the deprecated deps parameter.

To avoid importing partially-ordered-set.ts for its error types as well, DependencyNotFoundException and CircularDependencyFoundException have been moved to exception.ts so they remain exported from the package root after the deprecated file is eventually removed.
@clydin clydin added the target: minor This PR is targeted for the next minor release label Nov 16, 2026
@clydin
clydin marked this pull request as ready for review November 16, 2026 14:46
@clydin clydin added the action: review The PR is still awaiting reviews from at least one requested reviewer label Nov 16, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors CoreSchemaRegistry to use standard arrays instead of PartiallyOrderedSet for managing pre- and post-validation transforms. It introduces a helper function, addTransform, to handle transform insertion and dependency validation, and moves DependencyNotFoundException and CircularDependencyFoundException to the common exceptions module. Additionally, comprehensive unit tests have been added to verify the new transform ordering logic. There are no review comments, and I have no additional feedback to provide.

@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Nov 16, 2026
@clydin
clydin merged commit 63a1c6a into angular:main Nov 16, 2026
71 of 72 checks passed
@clydin

clydin commented Nov 16, 2026

Copy link
Copy Markdown
Member Author

This PR was merged into the repository. The changes were merged into the following branches:

@clydin
clydin deleted the refactor/remove-internal-partially-ordered-set branch November 16, 2026 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

action: merge The PR is ready for merge by the caretaker area: @angular-devkit/core target: minor This PR is targeted for the next minor release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants