Repository navigation
refactor(@angular-devkit/core): stop using PartiallyOrderedSet internally - #34729
Merged
clydin merged 1 commit intoNov 16, 2026
Merged
Conversation
…ally CoreSchemaRegistry was the only internal consumer of the deprecated PartiallyOrderedSet class. Replacing its _pre and _post fields with plain arrays and a small addTransform helper removes that dependency while preserving insertion order, deduplication, and support for the deprecated deps parameter. To avoid importing partially-ordered-set.ts for its error types as well, DependencyNotFoundException and CircularDependencyFoundException have been moved to exception.ts so they remain exported from the package root after the deprecated file is eventually removed.
clydin
marked this pull request as ready for review
November 16, 2026 14:46
There was a problem hiding this comment.
Code Review
This pull request refactors CoreSchemaRegistry to use standard arrays instead of PartiallyOrderedSet for managing pre- and post-validation transforms. It introduces a helper function, addTransform, to handle transform insertion and dependency validation, and moves DependencyNotFoundException and CircularDependencyFoundException to the common exceptions module. Additionally, comprehensive unit tests have been added to verify the new transform ordering logic. There are no review comments, and I have no additional feedback to provide.
alan-agius4
approved these changes
Nov 16, 2026
Member
Author
|
This PR was merged into the repository. The changes were merged into the following branches:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CoreSchemaRegistry was the only internal consumer of the deprecated PartiallyOrderedSet class. Replacing its _pre and _post fields with plain arrays and a small addTransform helper removes that dependency while preserving insertion order, deduplication, and support for the deprecated deps parameter.
To avoid importing partially-ordered-set.ts for its error types as well, DependencyNotFoundException and CircularDependencyFoundException have been moved to exception.ts so they remain exported from the package root after the deprecated file is eventually removed.