Repository navigation
fix(@angular/build): generate a separate server chunk for each preren… - #34723
Merged
alan-agius4 merged 1 commit intoNov 16, 2026
Merged
Conversation
…dered page Server asset chunks were named after the page path with `.` and `/` replaced by `_`, so pages such as `blog/archive` and `blog_archive` shared one chunk and one of them was served in place of the other. Chunk paths now mirror the page path. Fixes angular#34722
There was a problem hiding this comment.
Code Review
This pull request modifies the server-rendering manifest generation to use the original asset path directly for chunk file paths instead of replacing dots and slashes with underscores, preventing different assets from sharing the same chunk. A unit test has been added to verify this behavior. No review comments were provided, and I have no feedback to provide as the implementation is correct and well-tested.
Collaborator
Contributor
Author
|
@alan-agius4 As a question, can this be backported, or we only consider this a hardening? |
Collaborator
|
@SkyZeroZx We consider this a regular bug fix / hardening improvement rather than a security vulnerability. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…dered page
Server asset chunks were named after the page path with
.and/replaced by_, so pages such asblog/archiveandblog_archiveshared one chunk and one of them was served in place of the other. Chunk paths now mirror the page path.Fixes #34722
PR Checklist
Please check to confirm your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information