Skip to content

test: prevent SauceLabs browser E2E test timeout and disable unused shards - #34715

Merged
alan-agius4 merged 1 commit into
angular:mainfrom
alan-agius4:fix-saucelabs-e2e
Nov 13, 2026
Merged

alan-agius4 merged 1 commit into
angular:mainfrom
alan-agius4:fix-saucelabs-e2e

Conversation

@alan-agius4

Copy link
Copy Markdown
Collaborator

Batch devDependency installation in tests/misc/browsers.ts, increase per-test process timeout from 4 to 8 minutes to accommodate sequential SauceLabs browser sessions, and set shard_count = 1 for the saucelabs suite.

…hards

Batch devDependency installation in `tests/misc/browsers.ts`, increase per-test process timeout from 4 to 8 minutes to accommodate sequential SauceLabs browser sessions, and set `shard_count = 1` for the saucelabs suite.
@alan-agius4 alan-agius4 added action: review The PR is still awaiting reviews from at least one requested reviewer target: patch This PR is targeted for the next patch release action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Nov 13, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces support for installing multiple packages simultaneously in installPackage and updates the end-to-end test suite configuration, including adjusting shard counts and increasing the test timeout to 8 minutes. Feedback suggests dynamically setting the test timeout to 8 minutes only when SauceLabs is active (by checking SAUCE_USERNAME) to prevent delayed CI feedback for other tests, and adding a guard in installPackage to handle empty arrays safely.

Comment thread tests/e2e/utils/test_process.ts Resolved
Comment thread tests/e2e/utils/packages.ts Resolved
@alan-agius4
alan-agius4 merged commit ab12e4f into angular:main Nov 13, 2026
42 checks passed
@alan-agius4
alan-agius4 deleted the fix-saucelabs-e2e branch November 13, 2026 10:34
@alan-agius4

Copy link
Copy Markdown
Collaborator Author

This PR was merged into the repository. The changes were merged into the following branches:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants