Repository navigation
test: prevent SauceLabs browser E2E test timeout and disable unused shards - #34715
Merged
Merged
Conversation
…hards Batch devDependency installation in `tests/misc/browsers.ts`, increase per-test process timeout from 4 to 8 minutes to accommodate sequential SauceLabs browser sessions, and set `shard_count = 1` for the saucelabs suite.
There was a problem hiding this comment.
Code Review
This pull request introduces support for installing multiple packages simultaneously in installPackage and updates the end-to-end test suite configuration, including adjusting shard counts and increasing the test timeout to 8 minutes. Feedback suggests dynamically setting the test timeout to 8 minutes only when SauceLabs is active (by checking SAUCE_USERNAME) to prevent delayed CI feedback for other tests, and adding a guard in installPackage to handle empty arrays safely.
JeanMeche
approved these changes
Nov 13, 2026
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Batch devDependency installation in
tests/misc/browsers.ts, increase per-test process timeout from 4 to 8 minutes to accommodate sequential SauceLabs browser sessions, and setshard_count = 1for the saucelabs suite.