build: update dependency undici-types to v8 (main)#32934
build: update dependency undici-types to v8 (main)#32934angular-robot wants to merge 1 commit intoangular:mainfrom
Conversation
See associated pull request for more information.
There was a problem hiding this comment.
Code Review
This pull request updates the undici-types dependency from version 7 to 8 in both package.json and pnpm-lock.yaml. A review comment points out a significant version mismatch, as the project continues to use undici version 6.24.1. This discrepancy between the library and its type definitions could lead to misleading type-checking results and potential runtime issues due to breaking changes in the newer type definitions.
| }, | ||
| "resolutions": { | ||
| "undici-types": "^7.16.0" | ||
| "undici-types": "^8.0.0" |
There was a problem hiding this comment.
Updating undici-types to v8.0.0 while the project is still using undici@6.24.1 (as seen in pnpm-lock.yaml) creates a major version mismatch between the library and its type definitions. This version of types includes breaking changes and new defaults—such as enabling HTTP/2 by default and removing legacy handlers—that do not align with the v6.x runtime. This discrepancy can lead to misleading type-checking results where the compiler accepts code that may behave differently or fail at runtime. It is recommended to either update the undici package to v7+ or keep undici-types at v7.x to maintain consistency.
This PR contains the following updates:
^7.16.0→^8.0.0Release Notes
nodejs/undici (undici-types)
v8.0.1Compare Source
What's Changed
New Contributors
Full Changelog: nodejs/undici@v7.24.7...v8.0.1
v8.0.0Compare Source
What's Changed
Full Changelog: nodejs/undici@v7.24.7...v8.0.0