Skip to content

build: update dependency undici-types to v8 (main)#32934

Open
angular-robot wants to merge 1 commit intoangular:mainfrom
angular-robot:ng-renovate/main-undici-types-8-x
Open

build: update dependency undici-types to v8 (main)#32934
angular-robot wants to merge 1 commit intoangular:mainfrom
angular-robot:ng-renovate/main-undici-types-8-x

Conversation

@angular-robot
Copy link
Copy Markdown
Contributor

@angular-robot angular-robot commented Apr 3, 2026

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
undici-types (source) ^7.16.0^8.0.0 age adoption passing confidence

  • If you want to rebase/retry this PR, check this box

Release Notes

nodejs/undici (undici-types)

v8.0.1

Compare Source

What's Changed
New Contributors

Full Changelog: nodejs/undici@v7.24.7...v8.0.1

v8.0.0

Compare Source

What's Changed

Full Changelog: nodejs/undici@v7.24.7...v8.0.0

See associated pull request for more information.
@angular-robot angular-robot added action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project target: automation This PR is targeted to only merge into the branch defined in Github [bot use only] labels Apr 3, 2026
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the undici-types dependency from version 7 to 8 in both package.json and pnpm-lock.yaml. A review comment points out a significant version mismatch, as the project continues to use undici version 6.24.1. This discrepancy between the library and its type definitions could lead to misleading type-checking results and potential runtime issues due to breaking changes in the newer type definitions.

},
"resolutions": {
"undici-types": "^7.16.0"
"undici-types": "^8.0.0"
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Updating undici-types to v8.0.0 while the project is still using undici@6.24.1 (as seen in pnpm-lock.yaml) creates a major version mismatch between the library and its type definitions. This version of types includes breaking changes and new defaults—such as enabling HTTP/2 by default and removing legacy handlers—that do not align with the v6.x runtime. This discrepancy can lead to misleading type-checking results where the compiler accepts code that may behave differently or fail at runtime. It is recommended to either update the undici package to v7+ or keep undici-types at v7.x to maintain consistency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project target: automation This PR is targeted to only merge into the branch defined in Github [bot use only]

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant