feat(@angular/build): support middlewareConfig#32900
Open
tianma630 wants to merge 5 commits intoangular:mainfrom
Open
feat(@angular/build): support middlewareConfig#32900tianma630 wants to merge 5 commits intoangular:mainfrom
tianma630 wants to merge 5 commits intoangular:mainfrom
Conversation
angular-robot
bot
added
detected: feature
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a middlewareConfig option to the Angular dev-server, allowing users to provide a custom middleware configuration file. The implementation includes a new utility to load these configurations (supporting both ESM and CJS) and integrates them into the Vite server setup. Review feedback highlights several improvement opportunities: avoiding mutation of the middleware array to prevent side effects, ensuring cross-platform compatibility for dynamic imports on Windows, aligning type definitions with the schema, and cleaning up unused code in the test suite.
packages/angular_devkit/build_angular/src/builders/dev-server/builder.ts
Outdated
Show resolved
Hide resolved
...angular_devkit/build_angular/src/builders/dev-server/tests/options/middleware-config_spec.ts
Show resolved
Hide resolved
fixed Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Implement compatibility in the try-catch block Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
…builder.ts This is not necessary Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check to confirm your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #32811
What is the new behavior?
Allowing using middleware config in dev server options #32811
Does this PR introduce a breaking change?
Other information