refactor(@angular/build): extract headless configuration logic into helper function#32898
Merged
alan-agius4 merged 1 commit intoangular:mainfrom Mar 31, 2026
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request refactors the Vitest browser provider by extracting the headless configuration logic into a dedicated, exported function applyHeadlessConfiguration and adding comprehensive unit tests for it. The feedback identifies a redundant inline type import that should be replaced with the existing top-level import for better consistency.
packages/angular/build/src/builders/unit-test/runners/vitest/browser-provider.ts
Outdated
Show resolved
Hide resolved
clydin
force-pushed
the
vitest/chrome-bin-fix
branch
from
3ef98a4 to
be4ca40
Compare
…elper function This extracts the verbose headless property mutation logic from the monolithic setupBrowserConfiguration function into a standalone applyHeadlessConfiguration helper function to improve maintainability and readability.
clydin
force-pushed
the
vitest/chrome-bin-fix
branch
from
be4ca40 to
3bac7e2
Compare
clydin
added
action: review
alan-agius4
approved these changes
Mar 31, 2026
alan-agius4
added
action: merge
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This extracts the verbose headless property mutation logic from the monolithic setupBrowserConfiguration function into a standalone applyHeadlessConfiguration helper function to improve maintainability and readability.