Skip to content

Move TopicScreen strings to resources #2116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ois0886 wants to merge 1 commit into
base: main
Choose a base branch
from
+9 −4
Open

Move TopicScreen strings to resources #2116

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions feature/topic/api/src/main/res/values/strings.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,4 +16,8 @@
-->
<resources>
<string name="feature_topic_api_loading">Loading topic</string>
<string name="feature_topic_api_loading_news">Loading news</string>
<string name="feature_topic_api_news_error">Error</string>
<string name="feature_topic_api_following">Following</string>
<string name="feature_topic_api_not_following">Not following</string>
</resources>
9 changes: 5 additions & 4 deletions ...pl/src/main/kotlin/com/google/samples/apps/nowinandroid/feature/topic/impl/TopicScreen.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,7 @@ import com.google.samples.apps.nowinandroid.core.ui.TrackScreenViewEvent
import com.google.samples.apps.nowinandroid.core.ui.TrackScrollJank
import com.google.samples.apps.nowinandroid.core.ui.UserNewsResourcePreviewParameterProvider
import com.google.samples.apps.nowinandroid.core.ui.userNewsResourceCardItems
import java.util.Locale
import com.google.samples.apps.nowinandroid.core.ui.R as UiR
import com.google.samples.apps.nowinandroid.feature.topic.api.R as TopicR

Expand Down Expand Up @@ -246,11 +247,11 @@ private fun LazyListScope.userNewsResourceCards(
}

is NewsUiState.Loading -> item {
NiaLoadingWheel(contentDesc = "Loading news") // TODO
NiaLoadingWheel(contentDesc = stringResource(TopicR.string.feature_topic_api_loading_news))
}

else -> item {
Text("Error") // TODO
Text(stringResource(TopicR.string.feature_topic_api_news_error))
}
}
}
Expand Down Expand Up @@ -308,9 +309,9 @@ private fun TopicToolbar(
modifier = Modifier.padding(end = 24.dp),
) {
if (selected) {
Text("FOLLOWING")
Text(stringResource(TopicR.string.feature_topic_api_following).uppercase(Locale.getDefault()))
} else {
Text("NOT FOLLOWING")
Text(stringResource(TopicR.string.feature_topic_api_not_following).uppercase(Locale.getDefault()))
}
}
}
Expand Down